Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-1563 - Use iam_role_policy instead of deprecated inline policies #347

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Feb 25, 2025

Addresses https://uktrade.atlassian.net/browse/DBTP-1563

Fix these warnings every time we run a terraform command:

│ Warning: Argument is deprecated
│ 
│   with module.extensions.module.elasticache-redis["demodjango-redis"].aws_iam_role.conduit_ecs_task_role,
│   on .terraform/modules/extensions/elasticache-redis/main.tf line 88, in resource "aws_iam_role" "conduit_ecs_task_role":
│   88: resource "aws_iam_role" "conduit_ecs_task_role" {

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@JohnStainsby JohnStainsby requested a review from a team as a code owner February 25, 2025 10:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (3389320) to head (adbcbb5).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          709      709           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WillGibson WillGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JohnStainsby JohnStainsby merged commit d146e73 into main Feb 25, 2025
65 checks passed
@JohnStainsby JohnStainsby deleted the DBTP-1563-fix-deprecated-terraform-warnings branch February 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants