-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DBTP-1789 - Remove required pipelines config #338
fix: DBTP-1789 - Remove required pipelines config #338
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 7 7
Lines 868 868
=======================================
Hits 709 709
Misses 159 159 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large diff because I've added extra test blocks for the additional_ecr_repo
being public/private.
Also split out the big env var blocks to test individual variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the more targeted, hopefully less brittle, testing of the environment variables.
A couple of questions, but neither are blockers for me so approving.
Addresses https://uktrade.atlassian.net/browse/DBTP-1789
additional_ecr_repository
expects different formats e.g.demodjango/application
for private repos orpublic.ecr.aws/uktrade-platform-sandbox/demodjango/application
for publicChecklist:
Title:
Description:
Tasks: