Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-1789 - Remove required pipelines config #338

Merged
merged 21 commits into from
Feb 19, 2025

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Feb 14, 2025

Addresses https://uktrade.atlassian.net/browse/DBTP-1789

  • If no pipelines are listed don't deploy event bridge triggers
  • The additional_ecr_repository expects different formats e.g. demodjango/application for private repos or public.ecr.aws/uktrade-platform-sandbox/demodjango/application for public
    • Make the image exists check work with public and private ECR images
    • Ensure the correct IAM permissions are in place for public and private additional repos
  • Tidy up unnecessary pipelines variables

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (51ee145) to head (2b31cf1).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          709      709           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnStainsby JohnStainsby changed the title Dbtp 1789 remove required pipelines config fix: DBTP-1789 - Remove required pipelines config Feb 14, 2025
@JohnStainsby JohnStainsby marked this pull request as ready for review February 14, 2025 18:13
@JohnStainsby JohnStainsby requested a review from a team as a code owner February 14, 2025 18:13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large diff because I've added extra test blocks for the additional_ecr_repo being public/private.
Also split out the big env var blocks to test individual variables.

Copy link
Contributor

@WillGibson WillGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the more targeted, hopefully less brittle, testing of the environment variables.

A couple of questions, but neither are blockers for me so approving.

@JohnStainsby JohnStainsby merged commit 4c76c94 into main Feb 19, 2025
50 checks passed
@JohnStainsby JohnStainsby deleted the DBTP-1789-remove-required-pipelines-config branch February 19, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants