Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBTP-1738 Attach secret rotation lambda to correct VPC to ensure rotation tests pass #336

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

tony-griffin
Copy link
Contributor

@tony-griffin tony-griffin commented Feb 12, 2025

Addresses DBTP-1738

  • Testing with the Great service revealed that the lambda secret rotation tests failed when rotating the secret if the service was behind IP-Filter.
  • VPC config added on the lambda to ensure it is provisioned into the correct subnets and attaches the same security group as that attached to the Application Load Balancer to allow traffic through to the service, even with IP-Filter configured on the service for all paths, “/“

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (3389320) to head (7f8dc43).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          709      709           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony-griffin tony-griffin marked this pull request as ready for review February 14, 2025 15:37
@tony-griffin tony-griffin requested a review from a team as a code owner February 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants