Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple data migration bucket and role arns #320

Closed
wants to merge 2 commits into from

Conversation

ejayesh
Copy link
Contributor

@ejayesh ejayesh commented Jan 24, 2025

Addresses DBTP-1635

Ammendements to data-migration module to allow the use of multiple source bucket arns and multiple worker role arns.

Docs updated to highlight new feature. https://github.com/uktrade/platform-documentation/pull/455


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@ejayesh ejayesh requested a review from a team as a code owner January 24, 2025 18:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (155f371) to head (daa63a4).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files           5        5           
  Lines         814      814           
=======================================
  Hits          658      658           
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antroy-madetech
Copy link
Contributor

New approach merged from a different PR. Closing.

@WillGibson WillGibson deleted the DBTP-1635-multiple-worker-role-arns branch January 30, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants