Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing hardcoded value for S3 ENDPOINT #302

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

chiaramapellimt
Copy link
Contributor

@chiaramapellimt chiaramapellimt commented Dec 9, 2024

Addresses DBTP-1605

Please add any relevant context for you pull request here, or delete this if none needed.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@chiaramapellimt chiaramapellimt requested a review from a team as a code owner December 9, 2024 15:31
@chiaramapellimt chiaramapellimt marked this pull request as draft December 9, 2024 15:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5819fbc) to head (3077b98).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        50           
=========================================
  Hits            50        50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiaramapellimt chiaramapellimt marked this pull request as ready for review December 11, 2024 13:33
@chiaramapellimt chiaramapellimt merged commit cffd06a into main Dec 11, 2024
48 checks passed
@chiaramapellimt chiaramapellimt deleted the generalising-s3-endpoint branch December 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants