test: DBTP-1550 Add Codecov #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
WillGibson
force-pushed
the
DBTP-1550-Add-codecov
branch
from
30937be to
4411efe
Compare
WillGibson
commented
Nov 12, 2024
| fail-fast: false | ||
| matrix: | ||
| # If the matrix, you must also update after_n_builds in codecov.yml to match the number of times the test suite is run | ||
| python-version: ["3.12", "3.11"] |
There was a problem hiding this comment.
I did try slipping 3.13 in, but this felt out of scope...
_____________ ERROR collecting postgres/tests/test_manage_users.py _____________
ImportError while importing test module '/home/runner/work/terraform-platform-modules/terraform-platform-modules/postgres/tests/test_manage_users.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/importlib/__init__.py:88: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
postgres/tests/test_manage_users.py:10: in <module>
from postgres.manage_users import create_or_update_db_user, create_or_update_user_secret, handler
postgres/manage_users.py:3: in <module>
import psycopg2
../../../.cache/pypoetry/virtualenvs/non-package-mode-TIbHNkaA-py3.13/lib/python3.13/site-packages/psycopg2/__init__.py:51: in <module>
from psycopg2._psycopg import ( # noqa
E ImportError: /home/runner/.cache/pypoetry/virtualenvs/non-package-mode-TIbHNkaA-py3.13/lib/python3.13/site-packages/psycopg2/_psycopg.cpython-[31](https://github.com/uktrade/terraform-platform-modules/actions/runs/11802000815/job/32876648734#step:6:32)3-x86_64-linux-gnu.so: undefined symbol: _PyInterpreterState_Get
- generated xml file: /home/runner/work/terraform-platform-modules/terraform-platform-modules/junit.xml -
Something for another pull request.
There was a problem hiding this comment.
Do we also suuport a fewer older version of python, or is this based off the "2 latest versions" discusions we have been having
There was a problem hiding this comment.
The lambda uses Python 3.11 at the moment. I thought it would be worth testing newer versions too so we get early headsup if we write something that won't work with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://uktrade.atlassian.net/browse/DBTP-1550
Can be seen in action on https://app.codecov.io/github/uktrade/terraform-platform-modules/tree/DBTP-1550-Add-codecov