Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing all test-django unit tests #77

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

nboyse
Copy link
Collaborator

@nboyse nboyse commented Feb 11, 2025

Context

We have loads of broken unit tests we have inherited from i.ai. This fixes the remaining failing test-django unit tests which means now we can move onto creating new ones.

Changes proposed in this pull request

A variety of changes which means our test suite for test-django passes

Guidance to review

Check I havent done anything crazy

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@nboyse nboyse force-pushed the chore/fix-django-test branch 4 times, most recently from 80c247f to 951e079 Compare February 12, 2025 16:23
@nboyse nboyse marked this pull request as ready for review February 12, 2025 16:23
@nboyse nboyse changed the title update email/username relation chore: fixing all test-django unit tests Feb 12, 2025
@nboyse nboyse force-pushed the chore/fix-django-test branch from 45fb278 to 917f81d Compare February 13, 2025 15:25
Copy link
Contributor

@larry6point6 larry6point6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, tested locally and all tests pass and also passed in this PR (via the action)

@nboyse nboyse merged commit fff44ec into dev Feb 13, 2025
7 of 8 checks passed
@nboyse nboyse deleted the chore/fix-django-test branch February 13, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants