Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/search irrelevant query #118

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Conversation

nora-errouhly
Copy link
Contributor

removing BM25 and keeping semantic search only

@nora-errouhly
Copy link
Contributor Author

testing:

  • run redbox via docker compose or locally
  • through the UI , upload the document power_chapter.pdf
  • enter the prompt "what is the door about" and check that LLM does not hallucinate

Copy link
Contributor

@larry6point6 larry6point6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally looks good and works as described

@nora-errouhly nora-errouhly merged commit 37095ce into dev Feb 27, 2025
8 checks passed
nboyse added a commit that referenced this pull request Feb 28, 2025
* Spike LLM to choose route (#113)

* spike LLM to choose route

* add explanation why choosing metadata prompt

---------

Co-authored-by: Saisakul Chernbumroong <[email protected]>

* turn self route using env (#121)

* turn self route using env

* add SELF_ROUTE_ENABLED to env.example

---------

Co-authored-by: Saisakul Chernbumroong <[email protected]>

* Bugfix/search irrelevant query (#118)

* remove bm25 query

* understanding queries

* move notebook

* moving notebook to notebooks folder

---------

Co-authored-by: nora-errouhly <[email protected]>

* Add summarise graph (#115)

* add summarise graph

* add new summarise graph

* add keyword to test

---------

Co-authored-by: Saisakul Chernbumroong <[email protected]>

* feat: Copy Paste into chat box retains all formatting (#119)

* Feature/new search graph (#120)

* add new search graph

* add new search graph

* move set route node. Add clear documents.

* remove temp search

---------

Co-authored-by: Saisakul Chernbumroong <[email protected]>

* Feature/similarity score threshold (#127)

* remove bm25 query

* understanding queries

* move notebook

* moving notebook to notebooks folder

* setting similar score threshold

* linting

* fixing unit tests

---------

Co-authored-by: nora-errouhly <[email protected]>
Co-authored-by: Tash Boyse <[email protected]>
Co-authored-by: Natasha Boyse <[email protected]>

* feat: Intercept incompatible (not UTF-8) text on upload and handle .doc (#123)

* feat: Intercept incompatible (not UTF-8) text on upload and add functionality to convert doc to docx

* switch to if instead of elif in case both scenarios apply

---------

Co-authored-by: Saisakul Chernbumroong <[email protected]>
Co-authored-by: Saisakul Chernbumroong <[email protected]>
Co-authored-by: Nora Er-Rouhly <[email protected]>
Co-authored-by: nora-errouhly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants