Feature/similarity score threshold (#127)

* remove bm25 query * understanding queries * move notebook * moving notebook to notebooks folder * setting similar score threshold * linting * fixing unit tests --------- Co-authored-by: nora-errouhly <[email protected]> Co-authored-by: Tash Boyse <[email protected]> Co-authored-by: Natasha Boyse <[email protected]>
uktrade · Feb 28, 2025 · b030950 · b030950
1 parent 6ebecd4
commit b030950
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/redbox-core/redbox/retriever/queries.py b/redbox-core/redbox/retriever/queries.py
@@ -130,6 +130,7 @@ def build_document_query(
 
     return {
         "size": ai_settings.rag_k,
+        "min_score": 0.65,
         "query": {
             "bool": {
                 "must": [
@@ -138,7 +139,7 @@ def build_document_query(
                             "vector_field": {
                                 "vector": query_vector,
                                 "k": ai_settings.rag_num_candidates,
-                                "boost": ai_settings.knn_boost,
+                                # "boost": ai_settings.knn_boost,
                                 "filter": query_filter,
                             }
                         }

diff --git a/redbox-core/tests/retriever/test_retriever.py b/redbox-core/tests/retriever/test_retriever.py
@@ -7,7 +7,7 @@
 
 TEST_CHAIN_PARAMETERS = (
     {
-        "rag_k": 1,
+        "rag_k": 0,
         "rag_num_candidates": 100,
         "match_boost": 1,
         "knn_boost": 2,
@@ -19,7 +19,7 @@
         "rag_gauss_scale_max": 2.0,
     },
     {
-        "rag_k": 2,
+        "rag_k": 0,
         "rag_num_candidates": 100,
         "match_boost": 1,
         "knn_boost": 2,