-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support benchmarks #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Is it worth using mb.query()
or mb.match()
to test that the dummy data behaves as we expect?
Co-authored-by: Will Langdale <[email protected]>
… support_benchmarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending unit tests passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with new changes
Context
Changes proposed in this pull request
factories.py
out oftest
, intosrc/common
(because it's now used by the Postgres server benchmarks)test_transform.py
under common testsGuidance to review
Checklist: