Filter advice by team not user.team #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincarrogan
force-pushed
the
LTD-4899-use-static-team-on-advice
branch
3 times, most recently
from
c1bd748 to
65b5ec6
Compare
hnryjmes
reviewed
Apr 16, 2024
| @@ -78,7 +78,7 @@ Feature: I want to record my user advice and any comments and conditions relatin | |||
| When I click the application previously created | |||
| And I assign myself to the case | |||
| And I click the recommendations and decision tab | |||
| And I expand the details for "MOD-ECJU has approved with licence conditions" | |||
| And I expand the details for "MOD-CapProt has approved with licence conditions" | |||
There was a problem hiding this comment.
has this needed to change as a result of the other changes in this PR to filter by advice["team"]? or for some other reason?
There was a problem hiding this comment.
Yes. This test was written relying on the fact that previous advice given would follow the users team but now we are statically linking the team then this needed to change.
hnryjmes
approved these changes
Apr 16, 2024
kevincarrogan
force-pushed
the
LTD-4899-use-static-team-on-advice
branch
2 times, most recently
from
b42f3fe to
ed1891d
Compare
kevincarrogan
force-pushed
the
LTD-4899-use-static-team-on-advice
branch
from
ed1891d to
ca95855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
Use team field directly from the advice objects as opposed to looking up through the user.
This pairs with API changes that always store the team at a point in time instead of changing if the user changes team.
LTD-4899