Merge pull request #1892 from uktrade/LTD-4923-rename-url-path-for-de…

…nials-upload

LTD-4923-rename url path for denials upload

caseworker/external_data/urls.py

@@ -5,7 +5,9 @@
 app_name = "external_data"
 
 urlpatterns = [
-    path("denials/upload/", views.DenialUploadView.as_view(), name="denials-upload"),
+    path(
+        "denials/add-by-csv/", views.DenialUploadView.as_view(), name="denials-add-by-csv"
+    ),  # TODO: rename back to "denials/upload/" and "denials-upload" when we are ready to release this to users
     path("denials/<uuid:pk>/", views.DenialDetailView.as_view(), name="denial-detail"),
     path("denials/<uuid:pk>/revoke/", views.DenialRevokeView.as_view(), name="denial-revoke"),
 ]

unit_tests/caseworker/external_data/test_views.py

@@ -43,7 +43,9 @@ def mock_denial_patch(requests_mock):
 
 def test_upload_denial_404(authorized_client, mock_denial_upload, settings):
     # given the case has activity from system user
-    url = reverse("external_data:denials-upload")
+    url = reverse(
+        "external_data:denials-add-by-csv"
+    )  # TODO: rename back to ""denials-upload" when we are ready to release this to users
 
     file_path = os.path.join(settings.BASE_DIR, "caseworker/external_data/example.csv")
     data = {"csv_file": open(file_path, "rb")}
@@ -62,7 +64,9 @@ def test_upload_denial_404(authorized_client, mock_denial_upload, settings):
 @pytest.mark.skip(reason="CSV denials upload has been disabled")
 def test_upload_denial_valid_file(authorized_client, mock_denial_upload, settings):
     # given the case has activity from system user
-    url = reverse("external_data:denials-upload")
+    url = reverse(
+        "external_data:denials-add-by-csv"
+    )  # TODO: rename back to ""denials-upload" when we are ready to release this to users
 
     file_path = os.path.join(settings.BASE_DIR, "caseworker/external_data/example.csv")
     data = {"csv_file": open(file_path, "rb")}
@@ -80,7 +84,9 @@ def test_upload_denial_valid_file(authorized_client, mock_denial_upload, setting
 @pytest.mark.skip(reason="CSV denials upload has been disabled")
 def test_upload_denial_invalid_file(authorized_client, mock_denial_upload_validation_error, settings):
     # given the case has activity from system user
-    url = reverse("external_data:denials-upload")
+    url = reverse(
+        "external_data:denials-add-by-csv"
+    )  # TODO: rename back to ""denials-upload" when we are ready to release this to users
 
     file_path = os.path.join(settings.BASE_DIR, "caseworker/external_data/example.csv")
     data = {"csv_file": open(file_path, "rb")}