Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
kevincarrogan committed Apr 24, 2024
1 parent aae670a commit 71e705a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion caseworker/advice/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
LU_CONSOLIDATE_TEAMS = [FCDO_TEAM, MOD_ECJU_TEAM]
NCSC_TEAM = "NCSC"
OGD_TEAMS = [
*BEIS_TEAMS,
*DESNZ_TEAMS,
FCDO_TEAM,
*MOD_TEAMS,
NCSC_TEAM,
Expand Down
11 changes: 8 additions & 3 deletions unit_tests/caseworker/core/test_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,12 @@ def test_can_unassigned_user_assess_products(mock_gov_user, get_mock_request, mo
),
)
def test_can_user_review_and_combine_based_on_allocation(mock_gov_user, get_mock_request, case, expected_result):
case["advice"] = [{"user": {"team": {"alias": OGD_TEAMS[0]}}}]
case["advice"] = [
{
"user": {"team": {"alias": OGD_TEAMS[0]}},
"team": {"alias": OGD_TEAMS[0]},
},
]

user = mock_gov_user["user"]
request = get_mock_request(user)
Expand All @@ -392,8 +397,8 @@ def test_can_user_review_and_combine_based_on_allocation(mock_gov_user, get_mock
("advice", "expected"),
(
([], False),
([{"user": {"team": {"alias": LICENSING_UNIT_TEAM}}}], False),
*[([{"user": {"team": {"alias": alias}}}], True) for alias in OGD_TEAMS],
([{"user": {"team": {"alias": LICENSING_UNIT_TEAM}}, "team": {"alias": LICENSING_UNIT_TEAM}}], False),
*[([{"user": {"team": {"alias": alias}}, "team": {"alias": alias}}], True) for alias in OGD_TEAMS],
),
)
def test_can_user_review_and_combine_based_on_advice(mock_gov_user, get_mock_request, advice, expected):
Expand Down

0 comments on commit 71e705a

Please sign in to comment.