LTD-5939-f680-approval-doc-spike #2430
Draft
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currycoder
reviewed
Feb 25, 2025
| @@ -453,6 +453,15 @@ def get_unique_documents(self, final_advice, pk): | |||
| return latest_documents | |||
|
|
|||
|
|
|||
| class F680FinalAdviceDocuments(APIView): | |||
There was a problem hiding this comment.
I feel like for now this one should perhaps live in api/cases/generated_documents/
There was a problem hiding this comment.
It's also not F680 specific so I wonder if this could just be a caseworker URL under e.g. /caseworker/cases/<<case_uuid>>/generated_documents/
A DRF filter could perhaps be used to enable the frontend to get advice documents only e.g. enabling the frontend to filter results by only those which have an advice_type
Comment on lines
+13
to
+19
| <ul class="govuk-list govuk-list--bullet"> | ||
| {% for good in goods.refuse %} | ||
| <li> | ||
| {{good.good.name}} | ||
| </li> | ||
| {% endfor %} | ||
| </ul> |
There was a problem hiding this comment.
We can probably drop this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uktrade.atlassian.net/browse/LTD-5939
Approval letter for F680
This is a spike to get the approval letter working