Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDPF-92 Added redis, updated config files, added support for dbt-platform #4

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

0RWilliams
Copy link
Contributor

@0RWilliams 0RWilliams commented Oct 21, 2024

Updated Identity service with support for Redis, and DBT-Platform.
As part of the work to get this service deployed i have added:

  • dbt-copilot-python for checking the environment and setting up the database connections
  • dj-database-url for mapping the database connection string
  • replaced redis_url with IDENTITY_REDIS_URL and IDENTITY_REDIS to match dbt-terraform parameters.

I have also created a prod.py config file, and updated manage.py to default to prod.py ready for deployment.

Added Typing to config files (Not sure if we should go down this route, or if it's overkill)
Moved all Env declarations to the top of the file. (discussion point)

*Downgraded waitress to 2.1.2 as we had problems with this upgrade on several other services.

@0RWilliams 0RWilliams requested a review from a team as a code owner October 21, 2024 13:00
marcelkornblum
marcelkornblum previously approved these changes Oct 22, 2024
Copy link
Contributor

@marcelkornblum marcelkornblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's good.

Personally I'm not a fan of the settings file ordering, and while I approve of typing, I think it's overkill in the settings myself :)

@0RWilliams 0RWilliams requested a review from a team October 22, 2024 08:59
@alsyx alsyx merged commit 31aa570 into main Oct 31, 2024
4 checks passed
@alsyx alsyx deleted the IDPF-92 branch October 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants