Release #3024
Merged
Release #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update styling to cookie modal * Updates to styling for button * revert button styling * Fix overflow on modal * More styling updates and cookie confirmation wip * Fix syntax error in cookie notice string * More styling and accessibility improvements to the confirmation banner * recompile styles * Update ui tests * Reinstall npm packages and rebuild assets * Remove cookie notice as test * Remove cookie notice content as test * Remove translate function from cookie notice * Remove cookie notice content as test * Remove cookie notice content as test * Update preferences link code * Update preferences link code * Cleaned up styles from demo * Adjust robots.txt to see if it makes a difference to lighthouse * Attempt to debug lighthouse * reset lighthouse debugging * change lighthouse debugging * add defer to some js script references * Run the webserver as a step for lighthouse * revert and reduce score threshold for performance --------- Co-authored-by: Bobby Stearman <[email protected]>
GREATUK-597: Update performance dashboard banner wording
divyaparameswaran
approved these changes
Apr 18, 2024
stuart-mindt
pushed a commit
that referenced
this pull request
Jun 6, 2024
* GREATUK 40 - cookie modal accessibility updates (#3014) * Update styling to cookie modal * Updates to styling for button * revert button styling * Fix overflow on modal * More styling updates and cookie confirmation wip * Fix syntax error in cookie notice string * More styling and accessibility improvements to the confirmation banner * recompile styles * Update ui tests * Reinstall npm packages and rebuild assets * Remove cookie notice as test * Remove cookie notice content as test * Remove translate function from cookie notice * Remove cookie notice content as test * Remove cookie notice content as test * Update preferences link code * Update preferences link code * Cleaned up styles from demo * Adjust robots.txt to see if it makes a difference to lighthouse * Attempt to debug lighthouse * reset lighthouse debugging * change lighthouse debugging * add defer to some js script references * Run the webserver as a step for lighthouse * revert and reduce score threshold for performance --------- Co-authored-by: Bobby Stearman <[email protected]> * GREATUK-597: Update performance dashboard banner wording --------- Co-authored-by: Bobby Stearman <[email protected]> Co-authored-by: divyaparameswaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please add a sentence or two explaining the context of this PR. Reviewers can go to the ticket for detail.)
CONTEXT: This changeset adds/removes/updates [summary of feature/area/code] so that [summary of benefit].
Tick or delete as appropriate:
Workflow
Reviewing help
Housekeeping
make manage download_geolocation_datacommandMerging