Merge pull request #1355 from uktrade/develop

UAT release

CHANGELOG.md

@@ -4,6 +4,7 @@
 ### Enhancements
 - NOTICKET - update changelog, post-release
 ### Fixed bugs
+- GP2-2890 - DAC NonText Content 01
 - GP2-2835 - Disable caching on homepage
 - GP2-2889 - DAC Decorative_Images_01 - clear alt tags on decorative images
 - GP2-2888 - DAC Dialog_01 - aria-modal on confirmation dialogues.

config/settings.py

@@ -79,7 +79,6 @@
 ]
 
 MIDDLEWARE = [
-    'wagtailcache.cache.UpdateCacheMiddleware',
     'django.contrib.sessions.middleware.SessionMiddleware',
     'django.middleware.common.CommonMiddleware',
     'django.middleware.csrf.CsrfViewMiddleware',
@@ -93,7 +92,6 @@
     'core.middleware.UserSpecificRedirectMiddleware',
     'core.middleware.UserLocationStoreMiddleware',
     'core.middleware.StoreUserExpertiseMiddleware',
-    'wagtailcache.cache.FetchFromCacheMiddleware',
     'core.middleware.CheckGATags',
 ]
 

domestic/models.py

@@ -16,7 +16,6 @@
 from wagtail.core.models import Page
 from wagtail.images import get_image_model_string
 from wagtail.images.edit_handlers import ImageChooserPanel
-from wagtailcache.cache import WagtailCacheMixin
 
 from core import (
     blocks as core_blocks,
@@ -136,7 +135,6 @@ class DomesticHomePage(
     mixins.EnableTourMixin,
     mixins.AnonymousUserRequired,
     DataLayerMixin,
-    WagtailCacheMixin,
     Page,
 ):
     # Note that this is was the original homepage for Magna/V2 MPV.
@@ -163,10 +161,6 @@ class DomesticHomePage(
         ImageChooserPanel('image'),
     ]
 
-    # Deliberately asking wagtail not to cache homepage
-    def cache_control(self):
-        return 'no-cache'
-
 
 class DomesticDashboard(
     mixins.WagtailAdminExclusivePageMixin,

exportplan/templates/exportplan/dashboard_page.html

@@ -53,7 +53,7 @@ <h3 class="m-v-xs bold">Upload your logo</h3>
       </a>
     </div>
     {% else %}
-    <img alt="{{ request.user.company.name }}" src="{{ request.user.company.logo }}" class="width-full" />
+    <img alt="Your business logo" src="{{ request.user.company.logo }}" class="width-full" />
     <a id="edit-image" href="{% url 'exportplan:add-logo' %}" class="link pencil-link">Edit</a>
     {% endif %}
     <a class="button button--secondary button--full-width button--icon m-b-xs" href="{% url 'exportplan:pdf-download' %}" title="Save your plan as a PDF">

exportplan/templates/exportplan/includes/sidebar.html

@@ -8,7 +8,7 @@
                 {% if not request.user.company.logo %}
                     <img src="https://via.placeholder.com/200/dfd5c5?text=Company logo" alt="Add a business logo" class="w-1-2">
                 {% else %}
-                    <img alt="{{ request.user.company.name }}" src="{{ request.user.company.logo }}"  class="w-full"/>
+                    <img alt="Your business logo" src="{{ request.user.company.logo }}" class="w-full" />
                 {% endif %}
             </div>
             <ul>

tests/unit/domestic/test_models.py

@@ -1804,30 +1804,3 @@ def test_allowed_parents(self):
                 GreatDomesticHomePage,
             },
         )
-
-
-@pytest.mark.django_db
-def test_great_domestic_homepage_header_cache(root_page, client, user):
-
-    homepage = GreatDomesticHomePageFactory(
-        parent=root_page,
-        slug='root',
-    )
-
-    SiteFactory(
-        root_page=homepage,
-        hostname=client._base_environ()['SERVER_NAME'],
-    )
-
-    for user_logged_in in (False, True):
-
-        if user_logged_in:
-            client.force_login(user)
-
-        response = client.get(homepage.url)
-
-        assert response.has_header('Cache-Control') is True
-        assert response.get('Cache-Control') == 'no-cache'
-
-        assert response.has_header('X-Wagtail-Cache') is True
-        assert response.get('X-Wagtail-Cache') == 'skip'