Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter DNS queries from the datasets VPC using the Route53 Firewall #83

Merged
merged 1 commit into from
May 30, 2024

Conversation

michalc
Copy link
Member

@michalc michalc commented May 30, 2024

We don't know of any particular thing in the datasets VPC that allows users to make DNS queries, especially to unauthorised servers, so this is a defense in depth/just in case change. We are soon to put ArrangoDB in the dame VPC, so I think it makes sense to tighten things down as we increase the surface area otherwise.

It is set to only allow queries to amazonaws.com domains, and block everything else. While we might be able to block it further in future, this is a step forward in terms of locking things down.

In the notebooks VPC we have a similar setup, but with what is essentially our own custom firewall, written before the Route53 Firewall existed. If this goes well, potentially we could shut that down in favour of this for the notebooks VPC.

@michalc michalc requested a review from a team as a code owner May 30, 2024 14:22
@michalc michalc force-pushed the feat/dns-firewall-in-datasets-vpc branch 5 times, most recently from 72693f8 to 0c4ea9a Compare May 30, 2024 14:46
…wall

We don't know of any particular thing in the datasets VPC that allows users to
make DNS queries, especially to unauthorised servers, so this is a defense in
depth/just in case change. We are soon to put ArrangoDB in the dame VPC, so I
think it makes sense to tighten things down as we increase the surface area
otherwise.

It is set to only allow queries to amazonaws.com domains, and block everything
else. While we might be able to block it further in future, this is a step
forward in terms of locking things down.

In the notebooks VPC we have a similar setup, but with what is essentially our
own custom firewall, written before the Route53 Firewall existed. If this goes
well, potentially we could shut that down in favour of this for the notebooks
VPC.
@michalc michalc force-pushed the feat/dns-firewall-in-datasets-vpc branch from 0c4ea9a to 4396548 Compare May 30, 2024 14:48
@michalc michalc merged commit c9fdee4 into main May 30, 2024
1 check passed
@michalc michalc deleted the feat/dns-firewall-in-datasets-vpc branch May 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant