feat: allow logging of S3Sync/mobius3 metrics to CloudWatch #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
feat/allow-logging-to-cloudwatch
branch
4 times, most recently
from
df10d88 to
52ddaf0
Compare
michalc
changed the title
This adds the permission for each user to log S3Sync metrics to Cloudwatch, specifically ones added in https://github.com/uktrade/mobius3/releases/tag/v0.0.42 It also tightens up permissions on the Cloudwatch VPC endpoints, making sure that only our AWS accounts can use them.
michalc
force-pushed
the
feat/allow-logging-to-cloudwatch
branch
from
52ddaf0 to
9155f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the permission for each user to log S3Sync metrics to Cloudwatch, specifically ones added in https://github.com/uktrade/mobius3/releases/tag/v0.0.42
It also tightens up permissions on the Cloudwatch VPC endpoints, making sure that only our AWS accounts can use them.