Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/composite alarm scaling #246

Closed

Conversation

aidanrussell
Copy link

@aidanrussell aidanrussell commented Feb 13, 2025

This implements the composite alarms logic for scaling. It turned out that an explicit "composite alarm" as defined by AWS cannot be used for scaling. However, I was able to achieve the same thing with some hacking - I created a custom alarm consisting of several metrics and then I used a logic where TRUE=1 and FALSE=0 since AWS alarms require a continuous scale - you cannot explicitly use a boolean scale. Note that we may be exiting AWS recommended formats in the sense that I've had to hack this to some extent, there may be good reasons they are discouraging boolean settings for alarms - but to my mind it's sensible so let's see how it responds to typical user behaviour.

@aidanrussell aidanrussell requested a review from a team as a code owner February 13, 2025 21:58
@aidanrussell aidanrussell changed the base branch from main to feat/sagemaker-llms February 13, 2025 21:58
@aidanrussell aidanrussell changed the base branch from feat/sagemaker-llms to feat/sagemaker-llms-dev February 16, 2025 22:07
@aidanrussell aidanrussell deleted the feature/composite_alarm_scaling branch February 17, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant