WIP: Feature/composite alarm scaling #246
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the composite alarms logic for scaling. It turned out that an explicit "composite alarm" as defined by AWS cannot be used for scaling. However, I was able to achieve the same thing with some hacking - I created a custom alarm consisting of several metrics and then I used a logic where TRUE=1 and FALSE=0 since AWS alarms require a continuous scale - you cannot explicitly use a boolean scale. Note that we may be exiting AWS recommended formats in the sense that I've had to hack this to some extent, there may be good reasons they are discouraging boolean settings for alarms - but to my mind it's sensible so let's see how it responds to typical user behaviour.