Merge pull request #3385 from uktrade/fix/bump-node

Update node 16 -> 18
uktrade · Dec 5, 2024 · a097896 · a097896
2 parents c4077ce + 42d5fab
commit a097896
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,7 +4,7 @@ jobs:
   docker-test-unit-js:
     working_directory: ~/repo/dataworkspace/dataworkspace/static/js
     docker:
-      - image: cimg/node:16.20
+      - image: cimg/node:18.20.4
     steps:
       - checkout:
           path: ~/repo

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-alpine AS builder
+FROM node:18-alpine AS builder
 WORKDIR /app
 COPY dataworkspace/dataworkspace/static/js .
 RUN npm ci --include=dev
@@ -121,4 +121,4 @@ FROM base AS live
 
 CMD ["/dataworkspace/start.sh"]
 
-USER django
+USER django
diff --git a/dataworkspace/dataworkspace/static/js/package.json b/dataworkspace/dataworkspace/static/js/package.json
@@ -15,6 +15,9 @@
   "resolutions": {
     "cross-spawn": " 7.0.6"
   },
+  "engines": {
+    "node": "18"
+  },
   "dependencies": {
     "aws-sdk": "^2.1193.0",
     "ckeditor5": "^43.1.1",

diff --git a/package.json b/package.json
@@ -37,6 +37,9 @@
   "bugs": {
     "url": "https://github.com/uktrade/data-workspace/issues"
   },
+  "engines": {
+    "node": "18"
+  },
   "homepage": "https://github.com/uktrade/data-workspace#readme",
   "devDependencies": {
     "@testing-library/cypress": "^10.0.1",