CLS2-1299 Show edit history on EYB leads #7576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/CLS2-1299_EYB-edit-history
|
| Run status |
|
| Run duration | 01m 39s |
| Commit |
|
| Committer | Stuart Mindt |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7576 +/- ##
=======================================
Coverage 90.02% 90.03%
=======================================
Files 1122 1126 +4
Lines 17452 17485 +33
Branches 5044 5063 +19
=======================================
+ Hits 15712 15742 +30
- Misses 1740 1743 +3 ☔ View full report in Codecov by Sentry. |
cgsunkel
reviewed
Feb 26, 2025
src/client/modules/Investments/EYBLeads/EYBLeadEditHistory/transformers.js
Outdated
Show resolved
Hide resolved
ClaudiaGC1339
approved these changes
Feb 27, 2025
baarkerlounger
approved these changes
Feb 27, 2025
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 27, 2025
generated from commit fe5e5d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ability to list EYB lead change logs and link from the details page
Also added a optional param to the audit history component to show / hide the sort options. They're currently all showing but broken on all instances used. I set them all to be hidden as they're not required / supported by the APIs.
Test instructions
Tests added checking the change log page. They specifically check the transformations on the data are displayed correctly in the dom.
Screenshots
Before
N/A
After
Checklist