Export project interactions combined PR's #7533
Draft
+785
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/export-project-interactions-V2
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Paul Gain |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
dredmonds
force-pushed
the
feature/export-project-interactions-V2
branch
from
8b3663a to
110857c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7533 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 1122 1124 +2
Lines 17452 17469 +17
Branches 5044 5045 +1
=======================================
+ Hits 15713 15730 +17
Misses 1739 1739 ☔ View full report in Codecov by Sentry. |
* Layout test scenarios - Sort export project interaction list Sort a default company export interaction list * Added test coverage for company export interaction * Added export interaction collection list test * Update sandbox server `/v4/export/:exportId` endpoint error response * Fix export interaction tab navigation failing test * Moved a constant functions declaration Is a best practice to declare constant functions in the beginning of the codebase before calling, in order the javascript interpreter can locate. This action being reverted and noted as part of flakiness/tech debt. * Use interaction `subject` rather than export `title` Amend the current implementation of export interaction list by using `subject` rather than export interaction `title` on the list because is already on the header and repetitive each details .
Added test coverage for company export interaction
dredmonds
force-pushed
the
feature/export-project-interactions-V2
branch
from
5a4a709 to
514045a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A feature branch for export projects interactions:
Sort byfunctionality #7500Test instructions
Checklist