Migrate company edit history page to React Router #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51366 ↗︎
Details:
Review all test suite changes for PR #6548 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
feature/migrate-company-edithistory-to-rr
branch
from
2b9d6b8 to
736d196
Compare
paulgain
reviewed
Feb 22, 2024
src/client/modules/Companies/CompanyBusinessDetails/CompanyEditHistory/CompanyEditHistory.jsx
Outdated
Show resolved
Hide resolved
cgsunkel
force-pushed
the
feature/migrate-company-edithistory-to-rr
branch
4 times, most recently
from
e179c79 to
1a8393f
Compare
paulgain
approved these changes
Feb 23, 2024
3 tasks
DeanElliott96
approved these changes
Feb 26, 2024
cgsunkel
force-pushed
the
feature/migrate-company-edithistory-to-rr
branch
from
1a8393f to
875b833
Compare
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 26, 2024
generated from commit 6f42f28
swenban
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Refactor company edit history page to use React Router * Update and rewrite tests * Remove legacy code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The company Edit History page has been migrated to React Router. The deprecated
EditHistorycomponent originally used here has been replaced with aCollectionList(theEditHistorycomponent itself will be removed in an upcoming PR).I've included a couple of small changes as part of the switchover:
Global HQinstead ofghqTest instructions
The company edit history page should work as normal.
Screenshots
Before
After
Checklist