Refactor both export wins unconfirmed and confirmed tabs and URL paths #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51261 ↗︎
Details:
Review all test suite changes for PR #6547 ↗︎ |
|||||||||||||||
paulgain
changed the title
Due to a design change we need to refactor the wins that are displayed within the two tabs: -Refactor unconfirmed to sent -Refactoring confirmed to won
paulgain
force-pushed
the
refactor/refactor-export-wins
branch
from
535fe04 to
734e0a3
Compare
paulgain
changed the title
dredmonds
approved these changes
Feb 22, 2024
cgsunkel
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Due to a design change we need to refactor the export wins status name in both tabs:
These changes paves the way for a Rejected wins third tab.
Test instructions
Go to:
/exportwins/sent/exportwins/wonScreenshots
Before
Unconfirmed
Confirmed
After
Sent
Checklist