Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate OMIS reconciliation CollectionList to React Router #6541

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

cgsunkel
Copy link
Contributor

Description of change

The OMIS reconciliation list page has been migrated to React Router. This page has now been updated to prevent draft and quote_awaiting_acceptance orders from appearing in the list (as these orders cannot be reconciled).

Test instructions

Go to the OMIS reconciliation list. Everything should work as normal.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@cgsunkel cgsunkel requested a review from a team as a code owner February 20, 2024 13:48
Copy link

cypress bot commented Feb 20, 2024

Passing run #51205 ↗︎

0 24 0 0 Flakiness 0

Details:

Remove legacy code
Project: data-hub-frontend Commit: 37c4bb632b
Status: Passed Duration: 02:16 💡
Started: Feb 20, 2024 5:18 PM Ended: Feb 20, 2024 5:20 PM

Review all test suite changes for PR #6541 ↗︎

@cgsunkel cgsunkel force-pushed the feature/migrate-omis-reconciliation-to-rr branch from 79dbfec to 37c4bb6 Compare February 20, 2024 17:12
@cgsunkel cgsunkel merged commit 59ea8f6 into main Feb 21, 2024
16 checks passed
@cgsunkel cgsunkel deleted the feature/migrate-omis-reconciliation-to-rr branch February 21, 2024 16:41
chopkinsmade pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants