Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update export wins endpoint to use a hyphen instead of an underscore #6479

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Update export wins endpoint to use a hyphen instead of an underscore #6479

merged 1 commit into from
Feb 2, 2024

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Feb 1, 2024 •
edited
Loading

Description of change

  1. Updated the export wins endpoint to use a hyphen instead of an underscore.
  2. Update the company url so when clicking the company name when on the unconfirmed tab the user will be taken to the company details page.

Test instructions

In the dev environment go to /exportwins/unconfirmed where the page should load unconfirmed export wins.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner February 1, 2024 16:03
@cypress Cypress
Copy link

cypress bot commented Feb 1, 2024 •
edited
Loading

Passing run #50781 ↗︎

0 26 0 0 Flakiness 0

Details:

Change the export win endpoint to use a hyphen instead of an underscore
Project: data-hub-frontend Commit: 5aa0988794
Status: Passed Duration: 02:00 💡
Started: Feb 2, 2024 10:22 AM Ended: Feb 2, 2024 10:24 AM

Review all test suite changes for PR #6479 ↗︎

@paulgain paulgain changed the title Update export wins endpoint Update export wins endpoint to use a hyphen instead of an underscore Feb 2, 2024
@paulgain paulgain force-pushed the feature/update-export-wins-endpoint branch from a0ed51b to 4ea20f7 Compare February 2, 2024 09:26
@paulgain paulgain force-pushed the feature/update-export-wins-endpoint branch from 4ea20f7 to fb9e375 Compare February 2, 2024 10:13
@paulgain paulgain force-pushed the feature/update-export-wins-endpoint branch from fb9e375 to 5aa0988 Compare February 2, 2024 10:17
@paulgain paulgain merged commit c94b061 into main Feb 2, 2024
16 checks passed
@paulgain paulgain deleted the feature/update-export-wins-endpoint branch February 2, 2024 11:34
chopkinsmade pushed a commit that referenced this pull request Feb 2, 2024
publish: Merge pull request #6479 from uktrade/feature/update-export-…
7a9cdb6 
…wins-endpoint

generated from commit c94b061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ince-dbt ince-dbt ince-dbt left review comments

@elcct elcct elcct approved these changes

@dredmonds dredmonds dredmonds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgain @elcct @dredmonds @ince-dbt