Refactor company collection lists #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #50337 ↗︎
Details:
Review all test suite changes for PR #6439 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
feature/refactor-company-collection-lists
branch
2 times, most recently
from
4911142 to
e20972c
Compare
cgsunkel
commented
Jan 19, 2024
Comment on lines
+130
to
+131
| { url: '/companies/:companyId/hierarchies/ghq/:globalHqId/add' }, | ||
| { url: '/companies/:companyId/hierarchies/ghq/remove' }, |
There was a problem hiding this comment.
These pages only appear very briefly while the user is updating a Global HQ, which is causing flakiness in the a11y suite.
DeanElliott96
approved these changes
Jan 22, 2024
paulgain
reviewed
Jan 22, 2024
Comment on lines
+19
to
+21
| useEffect(() => { | ||
| document.title = `${pageTitle} - ${company.name} - Companies - DBT Data Hub` | ||
| }, [`${pageTitle} - ${company.name} - Companies - DBT Data Hub`]) |
There was a problem hiding this comment.
You may want to incorporate this new component into your PR.
There was a problem hiding this comment.
As the linked PR hasn't been merged to main yet and this PR is going into a feature-merge branch, would it be alright if I merge this now and make this change in a subsequent PR after Peter has merged his?
cgsunkel
force-pushed
the
feature-merge/company-layout-refactoring
branch
from
07458ad to
ff633a5
Compare
cgsunkel
force-pushed
the
feature/refactor-company-collection-lists
branch
from
c015e5e to
5c0a479
Compare
paulgain
approved these changes
Jan 22, 2024
cgsunkel
merged commit 17a8f26
into
feature-merge/company-layout-refactoring
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The company activity, contact and order tabs have been migrated to React Router.
Test instructions
The three pages mentioned above should work as normal.
Checklist