Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export Win - Officer details (1 of 6 steps) #6427

Merged
merged 8 commits into from
Jan 18, 2024

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Jan 11, 2024

Description of change

This is step 1 of 6 of the Export Win user journey that enables Lead Officers to add an Export Win to Data Hub.

Test instructions

Go to /exportwins/create?step=officer_details&company=<company-uuid>

  1. Enter all 4 fields (the last field is optional)
  2. Click continue
  3. Click back
  4. Ensure all data entered from 1. has persisted.

HQ team, region or post only appears once the user has selected a Team Type.

Screenshots

officer-details validation

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain requested a review from a team as a code owner January 11, 2024 14:52
Copy link

cypress bot commented Jan 11, 2024

Passing run #50240 ↗︎

0 24 0 0 Flakiness 0

Details:

Swap out component tests for functional tests
Project: data-hub-frontend Commit: 17e565f750
Status: Passed Duration: 02:06 💡
Started: Jan 17, 2024 8:33 AM Ended: Jan 17, 2024 8:35 AM

Review all test suite changes for PR #6427 ↗︎

@paulgain paulgain force-pushed the feat/officer-details-step branch from 73e6541 to c10fc85 Compare January 16, 2024 12:16
@paulgain paulgain changed the title Feat/officer details step Add Export Win - Officer details (1 of 6 steps) Jan 17, 2024
Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@paulgain paulgain merged commit 315826a into main Jan 18, 2024
3 checks passed
@paulgain paulgain deleted the feat/officer-details-step branch January 18, 2024 09:10
chopkinsmade pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants