Migrate business details page to React Router #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsunkel
changed the title
Passing run #50222 ↗︎
Details:
Review all test suite changes for PR #6416 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
feature/migrate-business-details-to-react-router
branch
2 times, most recently
from
033e26a to
2e5b56b
Compare
cgsunkel
force-pushed
the
feature/migrate-business-details-to-react-router
branch
from
2e5b56b to
3f47703
Compare
paulgain
reviewed
Jan 9, 2024
| }) => { | ||
| const { companyId } = useParams() | ||
| return ( | ||
| <CompanyResource id={companyId}> |
There was a problem hiding this comment.
We shouldn't be using any Resource at root, the layout has to come first. By using the Resource as root the entire page is blank until the API has responded. We don't want blank pages during an API request(s). Please take a look at Peter's recent work to understand how things have changed.
There was a problem hiding this comment.
Can you please point me to an example of where this new approach has been merged into main as I am not able to find anything matching this description in the last few PRs.
paulgain
approved these changes
Jan 18, 2024
cgsunkel
merged commit 1c4faae
into
feature-merge/company-layout-refactoring
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The business details page has now been migrated onto React Router.
Test instructions
The business details page should load as before
Checklist