Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Add Tasks button only appears in my tasks dashboard #6402

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

samuele-mattiuzzo
Copy link
Contributor

@samuele-mattiuzzo samuele-mattiuzzo commented Jan 5, 2024

Description of change

The "Add Task" component is currently being loaded in every tab, including unrelated ones, of a user's dashboard.
This PR moves where the button is being loaded to ensure it's only in the correct place.

Screenshots

Before

Screenshot 2024-01-05 at 11 15 13

Screenshot 2024-01-05 at 11 15 09

Screenshot 2024-01-05 at 11 15 05

Screenshot 2024-01-05 at 11 15 01

After

Screenshot 2024-01-05 at 11 12 08

Screenshot 2024-01-05 at 11 12 13

Screenshot 2024-01-05 at 11 12 1 8

Screenshot 2024-01-05 at 11 12 23

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)

Copy link

cypress bot commented Jan 5, 2024

Passing run #49872 ↗︎

0 76 7 0 Flakiness 0

Details:

Typo
Project: data-hub-frontend Commit: 6d52338ace
Status: Passed Duration: 08:20 💡
Started: Jan 5, 2024 11:36 AM Ended: Jan 5, 2024 11:44 AM

Review all test suite changes for PR #6402 ↗︎

@samuele-mattiuzzo samuele-mattiuzzo marked this pull request as ready for review January 5, 2024 11:32
@samuele-mattiuzzo samuele-mattiuzzo requested a review from a team as a code owner January 5, 2024 11:32
@samuele-mattiuzzo samuele-mattiuzzo merged commit c3799aa into main Jan 5, 2024
3 checks passed
@samuele-mattiuzzo samuele-mattiuzzo deleted the cls2-678-add-task-button-bug branch January 5, 2024 14:26
chopkinsmade pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants