Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebreak/upgrade-sandbox-to-es6-v2 #6399

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Jan 3, 2024

Description of change

  • Convert the sandbox api from CommonJS to ES6
  • Use the latest syntax for importing JSON files assert { type: 'json' }
  • Include the "@babel/plugin-syntax-import-assertions" plugin to allow the new import JSON syntax. Due to the lint:staged script being run at the root package.json level, this plugin had to be added into both the main app and the sandbox api

This PR is a duplicate of #6124, however due to some rebase issues a new branch was created

Test instructions

There should be no visible changes, running the sandbox api should still be possible with the existing commands. Due to the inclusion of some babel parsers, npm i needs to be run on both the main app and the sandbox api

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Jan 3, 2024

Passing run #49807 ↗︎

0 76 7 0 Flakiness 0

Details:

fix prettier issue
Project: data-hub-frontend Commit: 627daf2993
Status: Passed Duration: 08:21 💡
Started: Jan 3, 2024 3:35 PM Ended: Jan 3, 2024 3:43 PM

Review all test suite changes for PR #6399 ↗︎

@chopkinsmade chopkinsmade marked this pull request as ready for review January 3, 2024 15:46
@chopkinsmade chopkinsmade requested a review from a team as a code owner January 3, 2024 15:46
@chopkinsmade chopkinsmade merged commit c7ada1b into main Jan 4, 2024
3 checks passed
@chopkinsmade chopkinsmade deleted the firebreak/upgrade-sandbox-to-es6-v2 branch January 4, 2024 13:08
chopkinsmade pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants