-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/a11y testing #6398
Merged
PaulWheatcroft
merged 36 commits into
uktrade:feature/a11y-integration
from
PaulWheatcroft:feature/a11y-testing
Jan 3, 2024
Merged
Feature/a11y testing #6398
PaulWheatcroft
merged 36 commits into
uktrade:feature/a11y-integration
from
PaulWheatcroft:feature/a11y-testing
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Onyela Ogah <[email protected]>
… one file Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
…t be found Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
…inability Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
… one file Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
…t be found Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
…inability Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
Co-Authored-By: Onyela Ogah <[email protected]>
…oft/data-hub-frontend-made-tech into feature/a11y-testing
4d818f0
into
uktrade:feature/a11y-integration
3 checks passed
PaulWheatcroft
added a commit
that referenced
this pull request
Jan 9, 2024
* Configured Cypress A11y testing to run in the browser from the command Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to iterate through multiple routes in one file Co-Authored-By: Onyela Ogah <[email protected]> * Removed ARIA failing test for DropdownMenuGroup button Co-Authored-By: Onyela Ogah <[email protected]> * Added the ability to iterate to the next level of urls Co-Authored-By: Onyela Ogah <[email protected]> * Added support for multiple url variable identifiers Co-Authored-By: Onyela Ogah <[email protected]> * Sanitised A11y test variable names to make sense Co-Authored-By: Onyela Ogah <[email protected]> * Additional renaming it variables in A11y testing Co-Authored-By: Onyela Ogah <[email protected]> * Amended array creation to remove data endpoints Co-Authored-By: Onyela Ogah <[email protected]> * Added url exclusion mechanism for tests that fail for pages that can't be found Co-Authored-By: Onyela Ogah <[email protected]> * Added all mount points to A11y tests Co-Authored-By: Onyela Ogah <[email protected]> * Reworded variables to be be more logical Co-Authored-By: Onyela Ogah <[email protected]> * Documented how to use the accessibility tests Co-Authored-By: Onyela Ogah <[email protected]> * refactoring and decoupling the A11y implementation to increase maintainability Co-Authored-By: Onyela Ogah <[email protected]> * Added interaction spec Co-Authored-By: Onyela Ogah <[email protected]> * Sanitising URL exclusions Co-Authored-By: Onyela Ogah <[email protected]> * Updated documentation Co-Authored-By: Onyela Ogah <[email protected]> * Added interactions to A11y testing spec Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to run in the browser from the command Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to iterate through multiple routes in one file Co-Authored-By: Onyela Ogah <[email protected]> * Removed ARIA failing test for DropdownMenuGroup button Co-Authored-By: Onyela Ogah <[email protected]> * Added the ability to iterate to the next level of urls Co-Authored-By: Onyela Ogah <[email protected]> * Added support for multiple url variable identifiers Co-Authored-By: Onyela Ogah <[email protected]> * Sanitised A11y test variable names to make sense Co-Authored-By: Onyela Ogah <[email protected]> * Additional renaming it variables in A11y testing Co-Authored-By: Onyela Ogah <[email protected]> * Amended array creation to remove data endpoints Co-Authored-By: Onyela Ogah <[email protected]> * Added url exclusion mechanism for tests that fail for pages that can't be found Co-Authored-By: Onyela Ogah <[email protected]> * Added all mount points to A11y tests Co-Authored-By: Onyela Ogah <[email protected]> * Reworded variables to be be more logical Co-Authored-By: Onyela Ogah <[email protected]> * Documented how to use the accessibility tests Co-Authored-By: Onyela Ogah <[email protected]> * refactoring and decoupling the A11y implementation to increase maintainability Co-Authored-By: Onyela Ogah <[email protected]> * Added interaction spec Co-Authored-By: Onyela Ogah <[email protected]> * Sanitising URL exclusions Co-Authored-By: Onyela Ogah <[email protected]> * Updated documentation Co-Authored-By: Onyela Ogah <[email protected]> * Added interactions to A11y testing spec Co-Authored-By: Onyela Ogah <[email protected]> --------- Co-authored-by: Onyela Ogah <[email protected]>
PaulWheatcroft
added a commit
that referenced
this pull request
Jan 11, 2024
* Feature/a11y testing (#6398) * Configured Cypress A11y testing to run in the browser from the command Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to iterate through multiple routes in one file Co-Authored-By: Onyela Ogah <[email protected]> * Removed ARIA failing test for DropdownMenuGroup button Co-Authored-By: Onyela Ogah <[email protected]> * Added the ability to iterate to the next level of urls Co-Authored-By: Onyela Ogah <[email protected]> * Added support for multiple url variable identifiers Co-Authored-By: Onyela Ogah <[email protected]> * Sanitised A11y test variable names to make sense Co-Authored-By: Onyela Ogah <[email protected]> * Additional renaming it variables in A11y testing Co-Authored-By: Onyela Ogah <[email protected]> * Amended array creation to remove data endpoints Co-Authored-By: Onyela Ogah <[email protected]> * Added url exclusion mechanism for tests that fail for pages that can't be found Co-Authored-By: Onyela Ogah <[email protected]> * Added all mount points to A11y tests Co-Authored-By: Onyela Ogah <[email protected]> * Reworded variables to be be more logical Co-Authored-By: Onyela Ogah <[email protected]> * Documented how to use the accessibility tests Co-Authored-By: Onyela Ogah <[email protected]> * refactoring and decoupling the A11y implementation to increase maintainability Co-Authored-By: Onyela Ogah <[email protected]> * Added interaction spec Co-Authored-By: Onyela Ogah <[email protected]> * Sanitising URL exclusions Co-Authored-By: Onyela Ogah <[email protected]> * Updated documentation Co-Authored-By: Onyela Ogah <[email protected]> * Added interactions to A11y testing spec Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to run in the browser from the command Co-Authored-By: Onyela Ogah <[email protected]> * Configured Cypress A11y testing to iterate through multiple routes in one file Co-Authored-By: Onyela Ogah <[email protected]> * Removed ARIA failing test for DropdownMenuGroup button Co-Authored-By: Onyela Ogah <[email protected]> * Added the ability to iterate to the next level of urls Co-Authored-By: Onyela Ogah <[email protected]> * Added support for multiple url variable identifiers Co-Authored-By: Onyela Ogah <[email protected]> * Sanitised A11y test variable names to make sense Co-Authored-By: Onyela Ogah <[email protected]> * Additional renaming it variables in A11y testing Co-Authored-By: Onyela Ogah <[email protected]> * Amended array creation to remove data endpoints Co-Authored-By: Onyela Ogah <[email protected]> * Added url exclusion mechanism for tests that fail for pages that can't be found Co-Authored-By: Onyela Ogah <[email protected]> * Added all mount points to A11y tests Co-Authored-By: Onyela Ogah <[email protected]> * Reworded variables to be be more logical Co-Authored-By: Onyela Ogah <[email protected]> * Documented how to use the accessibility tests Co-Authored-By: Onyela Ogah <[email protected]> * refactoring and decoupling the A11y implementation to increase maintainability Co-Authored-By: Onyela Ogah <[email protected]> * Added interaction spec Co-Authored-By: Onyela Ogah <[email protected]> * Sanitising URL exclusions Co-Authored-By: Onyela Ogah <[email protected]> * Updated documentation Co-Authored-By: Onyela Ogah <[email protected]> * Added interactions to A11y testing spec Co-Authored-By: Onyela Ogah <[email protected]> --------- Co-authored-by: Onyela Ogah <[email protected]> * A11y tested integrated across the site * Refactored cursive urls and added aditional A11y issues to exclusions * Refactored cleanse function * App file structure changed * Removed pop in favour of !array.some method * Additional exclusion * Update readme.md * Linked docs/running tests to readme in a11y/config folder * Update readme.md * Update urlTestExclusions.js --------- Co-authored-by: Paul Wheatcroft <[email protected]> Co-authored-by: Onyela Ogah <[email protected]> Co-authored-by: Paul Wheatcroft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Document what the PR does and why the change is needed
Test instructions
What should I see?
Screenshots
Before
Add a screenshot
After
Add a screenshot
Checklist