Task component will now ignore starts of tasks which are already in #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #50247 ↗︎
Details:
Review all test suite changes for PR #6315 ↗︎ |
|||||||||||||||
peterhudec
force-pushed
the
task-coponent-dont-throw-if-in-progress
branch
from
8efe5c0 to
a3b8e17
Compare
cgsunkel
approved these changes
Jan 18, 2024
ince-dbt
approved these changes
Jan 18, 2024
dredmonds
approved these changes
Jan 18, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ow-if-in-progress generated from commit 685f005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the logic of starting a
Taskso that if when a task with the samenameandidis already in progress, it will ignore requests to start the task again, as opposed to the current behavior when an 'Cannot start task "." because it is already in progress. Cancel it first!' error is thrown.Test instructions
This change should not have any effect on the app's logic.
Checklist