Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebreak/move-support-files-out-of-functional-folder #6142

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Oct 9, 2023

Description of change

As the component and functional tests are using the helper functions in the test/functional/cypress/support folder, it makes sense to store these at the root test/ folder instead.

This PR does not change any existing functional or component tests, as tests are added / modified they should be updated to use the new file versions

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@cypress
Copy link

cypress bot commented Oct 9, 2023

Passing run #49837 ↗︎

0 24 0 0 Flakiness 0

Details:

added deprecated values
Project: data-hub-frontend Commit: d3fc2dee87
Status: Passed Duration: 02:06 💡
Started: Jan 4, 2024 1:41 PM Ended: Jan 4, 2024 1:43 PM

Review all test suite changes for PR #6142 ↗︎

@chopkinsmade chopkinsmade force-pushed the firebreak/move-support-files-out-of-functional-folder branch from 49c936f to 35ae99d Compare January 4, 2024 13:19
@chopkinsmade chopkinsmade marked this pull request as ready for review January 4, 2024 14:32
@chopkinsmade chopkinsmade requested a review from a team as a code owner January 4, 2024 14:32
@chopkinsmade chopkinsmade merged commit 6066738 into main Jan 5, 2024
3 checks passed
@chopkinsmade chopkinsmade deleted the firebreak/move-support-files-out-of-functional-folder branch January 5, 2024 09:18
chopkinsmade pushed a commit that referenced this pull request Jan 5, 2024
chopkinsmade added a commit that referenced this pull request Jan 5, 2024
chopkinsmade added a commit that referenced this pull request Jan 5, 2024
chopkinsmade pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants