Improving test coverage

uktrade · Feb 26, 2025 · bdd8fe6 · bdd8fe6
1 parent d9da732
commit bdd8fe6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/src/client/components/Resource/Paginated.js b/src/client/components/Resource/Paginated.js
@@ -156,7 +156,6 @@ const PaginatedResource = multiInstance({
                     shouldPluralize={shouldPluralize}
                     addItemUrl={addItemUrl}
                   />
-                  {showSort}
                   {totalPages > 0 && (
                     <StyledCollectionSort
                       totalPages={totalPages}

diff --git a/src/client/modules/Investments/EYBLeads/EYBLeadEditHistory/transformers.js b/src/client/modules/Investments/EYBLeads/EYBLeadEditHistory/transformers.js
@@ -1,4 +1,4 @@
-import { isBoolean, isNumber } from 'lodash'
+import { isBoolean } from 'lodash'
 
 import { EYB_LEAD_FIELD_NAME_TO_LABEL_MAP } from './constants'
 import { NOT_SET, YES, NO } from '../../../../components/AuditHistory/constants'
@@ -23,10 +23,6 @@ export const getValue = (value, field) => {
     return getValueFromBoolean(value, field)
   }
 
-  if (isNumber(value)) {
-    return value.toString()
-  }
-
   if (field === 'Where do you want to set up in the UK?') {
     return formatProposedInvestmentCity(value) || NOT_SET
   }

diff --git a/test/sandbox/fixtures/v4/investment/eyb-lead-audit.json b/test/sandbox/fixtures/v4/investment/eyb-lead-audit.json
@@ -78,6 +78,24 @@
                     "6-10"
                 ]
             }
+        },
+        {
+            "id": 754,
+            "user": {
+                "id": "64741bc5-b851-44ec-a565-75ec2e1a43cb",
+                "first_name": "",
+                "last_name": "",
+                "name": "",
+                "email": "[email protected]"
+            },
+            "timestamp": "2025-02-23T12:50:15.712184Z",
+            "comment": "Changed Proposed investment location none.",
+            "changes": {
+                "proposed_investment_location_none": [
+                    false,
+                    true
+                ]
+            }
         }
     ]
   }