Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the international telephone validator to allow hyphens in it #5407

Merged
merged 1 commit into from
May 10, 2024

Conversation

Richard-Pentecost
Copy link
Contributor

Description of change

User was finding they couldn't edit a contact without getting an error. On investigation it was due to the phone number (which wasn't being changed) having hyphens in it. The validation in the api didn't allow for hyphens. However, US numbers are often displayed with hyphens. This pr changes the international telephone validator to allow hyphens to be in the number.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@Richard-Pentecost Richard-Pentecost requested a review from a team as a code owner May 10, 2024 14:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (b51f9c7) to head (9d8d67b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5407   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         938      938           
  Lines       22330    22330           
  Branches     2002     2002           
=======================================
+ Hits        21524    21526    +2     
+ Misses        657      656    -1     
+ Partials      149      148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Richard-Pentecost Richard-Pentecost merged commit 3078ca0 into main May 10, 2024
2 checks passed
@Richard-Pentecost Richard-Pentecost deleted the fix/cps-568-contact-save-failure branch May 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants