Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor post-processing #258

Merged
merged 18 commits into from
Feb 5, 2024
Merged

Refactor post-processing #258

merged 18 commits into from
Feb 5, 2024

Conversation

pineapple-cat
Copy link
Collaborator

@pineapple-cat pineapple-cat commented Dec 20, 2023 •
edited
Loading

Addresses #244.

  • Perflog handler.
  • Config handler.
  • Modularise typing, sorting, filtering, and scaling.
  • Plot handler.

@pineapple-cat pineapple-cat linked an issue Dec 20, 2023 that may be closed by this pull request
Refactor post-processing #244
Closed
@pineapple-cat pineapple-cat marked this pull request as ready for review January 30, 2024 16:08
ilectra
ilectra reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@ilectra ilectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pretty good shape! Please make sure all FIXMEs are captured in issues.

post-processing/post_processing.py Show resolved Hide resolved
post-processing/post_processing.py Outdated Show resolved Hide resolved
post-processing/config_handler.py Outdated Show resolved Hide resolved
@pineapple-cat pineapple-cat merged commit 25330ed into main Feb 5, 2024
4 checks passed
@pineapple-cat pineapple-cat deleted the post-processing_refactor branch February 5, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilectra ilectra ilectra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor post-processing
2 participants
@pineapple-cat @ilectra