Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to CI setup #233

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Some improvements to CI setup #233

merged 1 commit into from
Nov 8, 2023

Conversation

giordano
Copy link
Member

@giordano giordano commented Nov 8, 2023

  • Use Dependabot to update CI workflows
  • Set RFM_CONFIG_FILES once for the entire build
  • Update actions/checkout to v4
  • Clone Spack with --depth=1
  • No need to reference $Python_ROOT_DIR for running the benchmarks

@giordano giordano requested a review from tkoskela November 8, 2023 11:24
* Use Dependabot to update CI workflows
* Set `RFM_CONFIG_FILES` once for the entire build
* Update `actions/checkout` to v4
* Clone Spack with `--depth=1`
* No need to reference `$Python_ROOT_DIR` for running the benchmarks
Copy link
Member

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't entirely understand what dependabot is doing, can you explain? Other changes look good.

Comment on lines +1 to +7
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do, does it update the versions of the actions used in the workflow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for example it'd have opened a PR to update

-     - uses: actions/checkout@v3
+     - uses: actions/checkout@v4

which I did manually here. It's useful to keep GHA workflows up to date.

@giordano giordano merged commit ec2e1f2 into main Nov 8, 2023
4 checks passed
@giordano giordano deleted the mg/ci branch November 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants