-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebooks #656
Merged
Merged
Notebooks #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding an example Jupyter notebook to test using a pull request.
Adds a unit testing file to test the example Jupyter notebook using testbook Creates a make target for testing notebooks Adds cells to the notebook that demonstrate writing a file to disk by rendering a template and yaml files to facilitate this Adds cells to the notebook that include cell magics
* update_values() -> update_from() (#578) * DRY out Driver._validate() (#579) * Move execute() to its own API namespace, disambiguate (#580) * Config classes to API (#582) * Simplify unknown-extension error message (#584) * UW-657 fs makedirs (#572) * Docstring cleanup (#585) * GH 586 bad stdin_ok prompt (#587) * Fix issue with creating a metatask dep. (#589) The rocoto schema is set up to allow metataskdep entries in the YAML, but the logic was not included in the tool to handle them. This addition fixes that. * Add --show-schema support to drivers (#588) * add file system notebook, unit tests, binder links * Add missing newlines * Add a table of contents * Makefile and .gitignore changes from review * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> * Apply review suggestions to all sections of the notebook * Specific rmtree() targeting and output cell test update * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> --------- Co-authored-by: Paul Madden <[email protected]> Co-authored-by: Christina Holt <[email protected]>
* WIP * WIP * WIP * Add config notebook, unit tests, Binder link & button * add newline * add markdown comment * add suggestions from review * apply suggestion from review * updating markdown comments and RtD links * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> * change error demo style and update section links * Apply suggestions from review * update testing * update RtD links and add uwtools version --------- Co-authored-by: Paul Madden <[email protected]>
* update_values() -> update_from() (#578) * DRY out Driver._validate() (#579) * Move execute() to its own API namespace, disambiguate (#580) * Config classes to API (#582) * Simplify unknown-extension error message (#584) * UW-657 fs makedirs (#572) * Docstring cleanup (#585) * GH 586 bad stdin_ok prompt (#587) * Fix issue with creating a metatask dep. (#589) The rocoto schema is set up to allow metataskdep entries in the YAML, but the logic was not included in the tool to handle them. This addition fixes that. * Add --show-schema support to drivers (#588) * Config notebook p2 and example notebook removal * removing merge diff text * pin python version for RtD * improvements from code review * add config.compare() format mismatch example * Remove typo Co-authored-by: Emily Carpenter <[email protected]> --------- Co-authored-by: Paul Madden <[email protected]> Co-authored-by: Christina Holt <[email protected]> Co-authored-by: Emily Carpenter <[email protected]>
* Rocoto notebook, tests, and links * Apply suggestions from code review Co-authored-by: NaureenBharwaniNOAA <[email protected]> * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> Co-authored-by: Christina Holt <[email protected]> * Changes from review * Update notebooks/rocoto.ipynb schemas typo fix Co-authored-by: Emily Carpenter <[email protected]> * cyclestring markdown change * Remove unnecessary logger mentions * Add nested metatask example * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> * Move nesting example to the end of metatask section --------- Co-authored-by: NaureenBharwaniNOAA <[email protected]> Co-authored-by: Paul Madden <[email protected]> Co-authored-by: Christina Holt <[email protected]> Co-authored-by: Emily Carpenter <[email protected]>
* Add notebook, unit tests, Binder link * Apply suggestions from code review Co-authored-by: Christina Holt <[email protected]> * Add user.PARMdir * Apply suggestions from code review Co-authored-by: Christina Holt <[email protected]> * Update Binder links * Add validation example using chgres_cube driver * Move header to binder_links.rst * Apply suggestions from review * Apply suggestions from code review Co-authored-by: Paul Madden <[email protected]> * notebook name change and driver validation update --------- Co-authored-by: Christina Holt <[email protected]> Co-authored-by: Paul Madden <[email protected]>
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA,
fgabelmannjr,
WeirAE and
Byrnetp
as code owners
November 19, 2024 21:06
Byrnetp
approved these changes
Nov 19, 2024
christinaholtNOAA
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Merge
notebooks
branch tomain
.Type
Impact
Checklist