-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UW-639 Mixed cyclestr / text support #606
Merged
maddenp-noaa
merged 9 commits into
ufs-community:main
from
maddenp-noaa:uw-639-cyclestr
Sep 12, 2024
Merged
UW-639 Mixed cyclestr / text support #606
maddenp-noaa
merged 9 commits into
ufs-community:main
from
maddenp-noaa:uw-639-cyclestr
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeirAE
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work, at least until we find another odd formatting to account for! Thanks for the quick fix!
elcarpenterNOAA
approved these changes
Sep 10, 2024
NaureenBharwaniNOAA
approved these changes
Sep 11, 2024
christinaholtNOAA
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Add UW YAML for Rocoto support for mixed
<cyclestr>
and text content by extending the definition ofcompoundTimeString
. Where, previously, only a single string, integer, orcyclestr:
block was allowed, now a sequence of these values is accepted, which is rendered as a mix of text and element XML children.For example, we can now realize
rocoto.yaml
as Rocoto XML
Type
Impact
Checklist