Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a !datetime tag. #597

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Add a !datetime tag. #597

merged 7 commits into from
Sep 3, 2024

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

Adds a !datetime tag and makes all tags lowercase.

Fixes user-identified gap identified in Discussion #595.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA self-assigned this Aug 29, 2024
maddenp-noaa
maddenp-noaa approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor suggestions.

docs/sections/user_guide/yaml/tags.rst Outdated Show resolved Hide resolved
src/uwtools/tests/config/test_jinja2.py Outdated Show resolved Hide resolved
src/uwtools/tests/config/test_support.py Outdated Show resolved Hide resolved
@christinaholtNOAA
Copy link
Collaborator Author

Oof! I did not realize I'd committed all the docs changes. I'm going to undo that and commit Paul's suggestions. Sorry about that!

WeirAE
WeirAE approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with those little changes!

Byrnetp
Byrnetp approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@Byrnetp Byrnetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christinaholtNOAA christinaholtNOAA merged commit dc9846d into ufs-community:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@Byrnetp Byrnetp Byrnetp approved these changes

@WeirAE WeirAE WeirAE approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@christinaholtNOAA @Byrnetp @WeirAE @NaureenBharwaniNOAA @maddenp-noaa @elcarpenterNOAA