Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW 500 - Allow YAML in all conversions #414

Merged
merged 33 commits into from
Feb 29, 2024
Merged

UW 500 - Allow YAML in all conversions #414

merged 33 commits into from
Feb 29, 2024

Conversation

WeirAE
Copy link
Contributor

@WeirAE WeirAE commented Feb 23, 2024 •
edited
Loading

Synopsis

YAML should always be accepted as input or output format. Documentation and tests must be updated appropriately

Completes issue #413

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds a new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)
  • This is a breaking change (changes existing functionality)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@WeirAE WeirAE added feature Added functionality refactor Refactor tech debt labels Feb 23, 2024
@WeirAE WeirAE self-assigned this Feb 23, 2024
@WeirAE WeirAE marked this pull request as draft February 23, 2024 17:10
@WeirAE WeirAE marked this pull request as ready for review February 27, 2024 20:13
@maddenp-noaa
Copy link
Collaborator

Given a.nml

&a i4(1:2)=88,88 /

the code on main can

% uw config realize --input-file a.nml --output-format nml
&a
    i4(1:2) = 88, 88
/

Are things ok on this branch if that changes to --output-format yaml?

WeirAE and others added 2 commits February 28, 2024 12:02
@WeirAE
Merge branch 'main' into UW-500
9554890
@WeirAE
Changes as follows below:
173909a 
Moved representers to support.py
Moved OrderedDict logic to its own representer
christinaholtNOAA
christinaholtNOAA requested changes Feb 28, 2024
View reviewed changes
src/uwtools/config/support.py Outdated Show resolved Hide resolved
@WeirAE WeirAE mentioned this pull request Feb 28, 2024
Closed
maddenp-noaa
maddenp-noaa reviewed Feb 28, 2024
View reviewed changes
src/uwtools/config/formats/yaml.py Outdated Show resolved Hide resolved
src/uwtools/config/formats/yaml.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
WeirAE and others added 9 commits February 28, 2024 14:58
@WeirAE WeirAE requested a review from maddenp-noaa February 28, 2024 22:22
maddenp-noaa
maddenp-noaa reviewed Feb 28, 2024
View reviewed changes
src/uwtools/config/support.py Show resolved Hide resolved
src/uwtools/config/support.py Outdated Show resolved Hide resolved
src/uwtools/tests/config/test_support.py Show resolved Hide resolved
christinaholtNOAA
christinaholtNOAA approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just needs a format push.

@WeirAE WeirAE merged commit 12c0ebc into ufs-community:main Feb 29, 2024
2 checks passed
@WeirAE WeirAE mentioned this pull request Feb 29, 2024
Closed
@WeirAE WeirAE deleted the UW-500 branch March 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

Assignees

@WeirAE WeirAE

Labels
feature Added functionality refactor Refactor tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeirAE @maddenp-noaa @christinaholtNOAA