Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use FIXorog instead of FIXgfs/orog #956

Merged
merged 1 commit into from
Jun 4, 2024
Merged

use FIXorog instead of FIXgfs/orog #956

merged 1 commit into from
Jun 4, 2024

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented May 31, 2024 •
edited by GeorgeGayno-NOAA
Loading

DESCRIPTION OF CHANGES:

This PR:

  • replaces FIXgfs/orog with a variable FIXorog.
  • FIXorog is defaulted to FIXgfs/orog
  • allows passing FIXorog from the calling script

TESTS CONDUCTED:

There is no change to source code or default behavior of the script.

  • Run unit tests locally on any Tier 1 machine. Done on Hercules using dbd4426. All tests passed.
  • Run global_cycle consistency test on any Tier 1 machine. Done on Hercules using dbd4426. All tests passed.

DEPENDENCIES:

None

DOCUMENTATION:

No change

ISSUE:

Resolves #955

CONTRIBUTORS:

@guoqing-noaa

@aerorahul aerorahul mentioned this pull request May 31, 2024
Merged
7 tasks
@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 2794d41 into ufs-community:develop Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeGayno-NOAA GeorgeGayno-NOAA GeorgeGayno-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace script variables ${FIXorog} with $(FIXgfs}/orog
2 participants
@aerorahul @GeorgeGayno-NOAA