chgres_cube: Add a check at static data read for incompatible old static data

[LarissaReames-NOAA]

DESCRIPTION OF CHANGES:

chgres_cube would produce incorrect surface data or fail with an unhelpful message in debug mode when used with old static data after PR #873 . I added a check in the read of the static fields that looks for any points where landfrac > 0 but static data = -999 (missing data). The program now fails at this point when used with incompatible static data and provides a useful error message directing the user to create new static data with an up-to-date UFS_UTILS build.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

• Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 8608666.
• Compile branch on Hera using GNU. Done using 8608666.
• Compile branch in 'Debug' mode on WCOSS2. Done using 8608666.
• Run unit tests locally on any Tier 1 machine. Done on Jet using 8608666.
• Run relevant consistency tests locally on all Tier 1 machine. The chgres_cube regression tests were tested using 8608666. All tests passed as expected.

Also tested with RRFS grib2 input data interpolating to the static data under fix.non.frac.grid/RRFS_CONUS_3km/ . A failure is successfully caused during the read of slope type from the static surface field and the desired output message is written to the log file.

Doxygen built with no warnings on WCOSS2 using 8608666.

DEPENDENCIES:

N/A

DOCUMENTATION:

N/A

ISSUE:

Addresses #906

[GeorgeGayno-NOAA]

And you tested this on your problem case? Can you note that under the 'tests conducted' section.

[GeorgeGayno-NOAA]

@LarissaReames-NOAA - I just have three minor comments. Once you address them I can merge.

[GeorgeGayno-NOAA]

Please merge the latest updates from develop. Then, I will approve and merge.

[GeorgeGayno-NOAA]

Doxygen now builds without error using 5c99fb6.

[LarissaReames-NOAA]

Doxygen now builds without error using 5c99fb6.

Done.

[GeorgeGayno-NOAA]

Looks good. Will merge.

[GeorgeGayno-NOAA]

@LarissaReames-NOAA and @BenjaminBlake-NOAA Is this fix required for RRFSv1? If so, I will need to update the tag: https://github.com/ufs-community/UFS_UTILS/releases/tag/ufs_utils_1_12_2

[BenjaminBlake-NOAA]

@GeorgeGayno-NOAA Since this issue came about after PR #873 was merged, I don't think so. The tag for RRFSv1 was created just before the changes associated with 873.