Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atmosphere.F90 add "action='read'" to Fortran file open statement #870

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

climbfuji
Copy link
Contributor

@climbfuji climbfuji commented Nov 9, 2023

DESCRIPTION OF CHANGES:

Add "action='read'" to Fortran file open statement in chgres_cube's atmosphere.F90 to fix the issue described in #869.

TESTS CONDUCTED:

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). Done using b529162.
  • Compile branch on Hera using GNU. Done using b529162.
  • Compile branch in 'Debug' mode on WCOSS2. Done using b529162.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using b529162.
  • Run relevant consistency tests locally on all Tier 1 machine. Done on Hera using b529162.

Describe any additional tests performed.

  • Compiled on AWS ParallelCluster with Intel 2021.4.0, ran successfully as part of JEDI-Skylab

DEPENDENCIES:

n/a

DOCUMENTATION:

n/a

ISSUE:

Resolves #869

@climbfuji
Copy link
Contributor Author

Wow, what did I do??? https://github.com/ufs-community/UFS_UTILS/actions/runs/6816948729/job/18539410762

@GeorgeGayno-NOAA
Copy link
Collaborator

Wow, what did I do??? https://github.com/ufs-community/UFS_UTILS/actions/runs/6816948729/job/18539410762

That test always breaks. I have no idea why. Rerunning it usually fixes it. Just click on the circular arrows for that test.

@climbfuji
Copy link
Contributor Author

Wow, what did I do??? https://github.com/ufs-community/UFS_UTILS/actions/runs/6816948729/job/18539410762

That test always breaks. I have no idea why. Rerunning it usually fixes it. Just click on the circular arrows for that test.

Thanks, that worked.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review November 13, 2023 20:32
@GeorgeGayno-NOAA
Copy link
Collaborator

Thanks @climbfuji. Will merge.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 2f8675f into develop Nov 17, 2023
8 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/chgres_cube_fopen_read branch November 17, 2023 18:45
@climbfuji
Copy link
Contributor Author

Thanks very much @GeorgeGayno-NOAA !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "action='read'" to chgres_cube Fortran file open statement
2 participants