Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocean_merge - Increase directory path variable length #1003

Merged
merged 1 commit into from
Dec 9, 2024
Merged

ocean_merge - Increase directory path variable length #1003

merged 1 commit into from
Dec 9, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Dec 4, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

Some of the path variables do not have enough characters.

TESTS CONDUCTED:

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using c1a84df.
  • Compile branch on Hera using GNU. Done using c1a84df.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Dogwood using c1a84df.
  • Run unit tests locally on any Tier 1 machine. Done on Hera (with Gnu) using c1a84df.
  • Run grid_gen consistency tests locally on all Tier 1 machines. Done using c1a84df. All tests passed as expected.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #1002.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review December 4, 2024 20:27
sanatcumar
sanatcumar approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@sanatcumar sanatcumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled c1a84df, no issues noticed.

sorc/ocean_merge.fd/merge_lake_ocnmsk.F90 Show resolved Hide resolved
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@sanatcumar thanks for your prompt review.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 4630b7d into ufs-community:develop Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanatcumar sanatcumar sanatcumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase path variable length in ocean_merge
2 participants
@GeorgeGayno-NOAA @sanatcumar