Página Inicial #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnogueira
requested changes
Jan 20, 2021
| lineHeight: 27px; | ||
| color: #ffffff; | ||
| borderWidth: 2px; | ||
| borderColor: #f5f5f5; |
There was a problem hiding this comment.
A gente precisa ver também uma forma de passar essas colors padrão aí pra os filhos. Atualmente, estamos usando as cores em cada local. O melhor é padronizarmos em um arquivo e importamos ele aqui e usarmos. Assim, no dia que modificarmos, já teremos tudo alterado de uma vez. Além disso, faz com que a gente siga um padrão. Às vezes tem uma cor super parecida com a que já temos no arquivo de cores, então a gente substitui a do design e usa a do padrão, o que ajuda a manter um padrão de cores em toda a aplicação 💡.
There was a problem hiding this comment.
@lcnogueira boa ideia, vou abrir uma issue pra isso: #15
lcnogueira
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1
Página inicial do App com mocks e estado de loading nos cards