Skip to content

Commit

Permalink
fixup tests and workflow 2x
Browse files Browse the repository at this point in the history
  • Loading branch information
dafeliton committed Dec 29, 2024
1 parent a694103 commit 3069357
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ on:
workflow_dispatch:
inputs:
prepull_images:
description: "Prepull images prior to build"
description: "Skip image prepull prior to build"
required: false
type: boolean
default: false
Expand Down
2 changes: 1 addition & 1 deletion images/datascience-notebook/test/test_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
LOGGER = logging.getLogger('datahub_docker_stacks')


def test_python_version(container, python_next_version="3.12"):
def test_python_version(container, python_next_version="3.13"):
"""Check that python version is lower than the next version"""
LOGGER.info(f"Checking that python version is lower than {python_next_version}")
c = container.run(
Expand Down
3 changes: 2 additions & 1 deletion scripts/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ def build_and_test_containers(
It will be built from stable image's cache and save future build time.")
node_order[i].rebuild = True
last_t, m, s = get_time_duration(last_t)
logger.info(f"TIME: Prepull took {m} mins {s} secs")
if not skip_prepull:
logger.info(f"TIME: Prepull took {m} mins {s} secs")

# MAIN loop: look at image one by one
for node in node_order:
Expand Down

0 comments on commit 3069357

Please sign in to comment.