Update About Page Leadership Section #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snigdha-kansal
approved these changes
Feb 6, 2025
pages/about.js
Outdated
| const convertedData = officerContent.map(officer => ({ | ||
| name: officer.name, | ||
| pronouns: officer.pronouns, | ||
| position: (officer.role === officer.committee ? officer.role : officer.role + ', ' + officer.committee), |
There was a problem hiding this comment.
Will need to update position to role to match offoutput.json and in turn what OfficerCard component expects.
pages/about.js
Outdated
| committee: officer.committee, | ||
| major: officer.major, | ||
| year: officer.year, | ||
| img: officer.photo, |
There was a problem hiding this comment.
Will need to update img to photo to match offoutput.json and in turn what OfficerCard component expects.
pages/about.js
Outdated
| major: officer.major, | ||
| year: officer.year, | ||
| img: officer.photo, | ||
| })).filter(officer => officer.position.includes('President')); |
There was a problem hiding this comment.
Same here, will need to update position to role to match offoutput.json and in turn what OfficerCard component expects.
next.config.js
Outdated
| 'www.uclaacm.com', | ||
| 'raw.githubusercontent.com', | ||
| 't4.ftcdn.net', |
There was a problem hiding this comment.
this (t4.ftcdn.net) appears twice
pages/about.js
Outdated
| @@ -6,17 +6,32 @@ import React from 'react'; | |||
| import Banner from '../components/Banner'; | |||
| import Layout from '../components/Layout'; | |||
| import Officers from '../components/OfficerCard'; | |||
| // import Officers from '../components/Officers/OfficerCard'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #684. We now use the parser script generated data to populated the leadership section on the "About" page. Note that the current implementation requires the generated json to be within the "scripts" folder.
Changes
pages/about.jsnext.config.js